Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SQL queries in crypto tutorial part 2 to work with static crypto dataset #3668

Open
wants to merge 4 commits into
base: latest
Choose a base branch
from

Conversation

combscCode
Copy link

Description

The dataset for the crypto tutorials seem to have stopped updating on Nov 22, 2023. This means that the SQL queries in the tutorial now return nothing. This PR updates all of the NOW() calls used throughout the tutorial to work with the dates that are within the dataset currently.

An alternative to merging this PR would be to keep the crypto dataset up to date, but not sure how y'all would prefer to fix the issue.

Links

Fixes #[insert issue link, if any]
Fixes #3667

Writing help

For information about style and word usage, see the style guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@billy-the-fish
Copy link
Contributor

@jonatas , can you have a quick look at this please.

@billy-the-fish
Copy link
Contributor

@combscCode hope you don't mind, but I updated the description about the dataset for clarity.

@combscCode
Copy link
Author

@combscCode hope you don't mind, but I updated the description about the dataset for clarity.

no worries! I found a couple other instances of 'updated daily' being used, pushed a commit that removes them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants