-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify SQL queries in crypto tutorial part 2 to work with static crypto dataset #3668
base: latest
Are you sure you want to change the base?
Conversation
|
@jonatas , can you have a quick look at this please. |
Signed-off-by: Iain Cox <[email protected]>
@combscCode hope you don't mind, but I updated the description about the dataset for clarity. |
no worries! I found a couple other instances of 'updated daily' being used, pushed a commit that removes them as well. |
Description
The dataset for the crypto tutorials seem to have stopped updating on Nov 22, 2023. This means that the SQL queries in the tutorial now return nothing. This PR updates all of the NOW() calls used throughout the tutorial to work with the dates that are within the dataset currently.
An alternative to merging this PR would be to keep the crypto dataset up to date, but not sure how y'all would prefer to fix the issue.
Links
Fixes #[insert issue link, if any]
Fixes #3667
Writing help
For information about style and word usage, see the style guide
Review checklists
Reviewers: use this section to ensure you have checked everything before approving this PR:
Subject matter expert (SME) review checklist
Documentation team review checklist
and have they been implemented?