Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-node deprecation warning #3547

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

Add multi-node deprecation warning #3547

wants to merge 2 commits into from
+4 −0

Conversation

jonatas
Copy link
Contributor

@jonatas jonatas commented Oct 30, 2024 •
edited
Loading

Description

I just see that data_nodes informational view does not have the deprecation notice. Just copied the import from other files.

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@github-actions GitHub Actions
Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-add-deprecation-warning-to-data-nodes

@jonatas jonatas mentioned this pull request Oct 30, 2024
Open
billy-the-fish
billy-the-fish approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billy-the-fish
Update data_nodes.md
11f63c5 
Signed-off-by: Iain Cox <[email protected]>
jonatas
jonatas commented Oct 31, 2024
View reviewed changes
api/data_nodes.md
# timescaledb_information.data_nodes

Get information on data nodes. This function is specific to running
TimescaleDB in a multi-node setup.

<MultiNodeDeprecation />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @billy-the-fish! I end up just grepping and missed the tag 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy-the-fish billy-the-fish billy-the-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatas @billy-the-fish