-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note to prev expression return type for locf() #3486
base: latest
Are you sure you want to change the base?
Conversation
I noted that we lack examples for using the |
Sounds like a good idea! I am willing to do that. Should I add another PR since this one is already approved? |
Just added the two examples here. Could still move that to another PR, if you prefer. |
I have approved the text that you submitted, so you might want to submit this as a separate PR. |
Just noted. Will check them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I suggest some minor rewrites:
- "that is" and "for example" give a better flow of the text than "i.e." and "e.g."
- Would be nice with an elaboration, even if informal, why time is needed in one place and not the other. I added a suggestion, but feel free to modify it.
- The queries are using an exclusive range condition, so just checking that this was intentional and not a mistake.
Co-authored-by: Mats Kindahl <[email protected]> Signed-off-by: cracksalad <[email protected]>
Co-authored-by: Mats Kindahl <[email protected]> Signed-off-by: cracksalad <[email protected]>
Description
After using
interpolate()
for years now, I usedlocf()
for the first time and came across a difference in theirprev
parameters, precisely in their return types: Whileinterpolate()
expects a tuple like(time, value)
,locf()
expects just a value. I thought that should also be noted in the docs (as is forinterpolate()
but not forlocf()
).Links
No issue link, but link to current
locf()
doc: https://docs.timescale.com/api/latest/hyperfunctions/gapfilling/time_bucket_gapfill/#locfReview checklists
Reviewers: use this section to ensure you have checked everything before approving this PR:
Subject matter expert (SME) review checklist
Documentation team review checklist
and have they been implemented?