-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new visit pass again to fix select short sight #380
base: develop
Are you sure you want to change the base?
Conversation
Not ready for merge and need a test I will discuss more details tomorrow with colleagues |
when we first start scan/parse the proton/src/Interpreters/RequiredSourceColumnsData.cpp Lines 56 to 72 in 8ef6c22
but I cannot understand why we already have to re-scan again but still will have this problem. |
the sql filed shall be small enough, the plain manual loop perf is enough compared with `std::ranges::all_of` but more read-able? https://quick-bench.com/q/azeLdyzDIqFnBYNokyg4K1HB6os
…ix-select-short-sighted
``` // src/Interpreters/RequiredSourceColumnsData.cpp:10 bool RequiredSourceColumnsData::addColumnAliasIfAny(const IAST & ast) { if (required_names.contains(alias)) masked_columns.insert(alias); complex_aliases.insert(alias); return true; } ```
PR checklist:
proton: starts/ends
for new code in existing community code base ?Please write user-readable short description of the changes:
fix #356