Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove sidebar #153

Merged
merged 2 commits into from
May 14, 2024
Merged

feat: remove sidebar #153

merged 2 commits into from
May 14, 2024

Conversation

Levdbas
Copy link
Member

@Levdbas Levdbas commented May 2, 2024

Related:

Issue

Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.

Solution

This particular PR focusses on deleting the sidebar files. Since Gutenberg is introduced, I rarely see widgets being used in the wild. With widgets getting deprecated, I think it is time to say farewell to the sidebar.

Impact

No more sidebars, so cleaner code.

Usage Changes

Minimal, I think when you create a new site nowaydays, developers are not using the sidebar/widgets functions that much. For the few folks that still stick to it, the can re-add this functionality in a way they see fit.

Considerations

Not dumping the sidebar yet?

Testing

I might try to add some overall tests in the upcoming few PR's

@Levdbas Levdbas merged commit 5ffdc0c into 2.x May 14, 2024
4 of 9 checks passed
@Levdbas Levdbas deleted the delete-sidebar branch May 14, 2024 07:37
@Levdbas Levdbas mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants