Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'shield_text' property on roads #966

Merged
merged 10 commits into from
Aug 12, 2016
Merged

Add 'shield_text' property on roads #966

merged 10 commits into from
Aug 12, 2016

Commits on Aug 12, 2016

  1. Don't rely on 'network' for bicycle networks, use 'bicycle_network' i… 

    …nstead.
    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    3d90278 View commit details
    Browse the repository at this point in the history

  2. Fetch all networks for a road, and sort them to find the most importa… 

    …nt. Use the 'ref' from that relation to form the 'shield_text' output property.
    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    945273f View commit details
    Browse the repository at this point in the history

  3. Add test case for networks and network sorting.

    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    594b0e2 View commit details
    Browse the repository at this point in the history

  4. If we're dropping network, then shield_text is useless - the network … 

    …determines which shield to use.
    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    3686b08 View commit details
    Browse the repository at this point in the history

  5. Add documentation for new 'shield_text' property. Clarify other prope… 

    …rties in relation to it.
    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    8a5e132 View commit details
    Browse the repository at this point in the history

  6. Add cleanup for old, replaced version of the function.

    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    09be38e View commit details
    Browse the repository at this point in the history

  7. Don't stringify - keep as array through JSON.

    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    861ac6d View commit details
    Browse the repository at this point in the history

  8. Simplify code by rewriting as a list comprehension.

    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    99ea802 View commit details
    Browse the repository at this point in the history

  9. Expose all networks & shield texts for use with multiple shield capab… 

    …le renderers.
    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    62375da View commit details
    Browse the repository at this point in the history

  10. Be deeper about freezing properties dictionaries for road merging.

    Matt Amos committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    bba8a95 View commit details
    Browse the repository at this point in the history