-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add historic and castle_type tags #1927
base: master
Are you sure you want to change the base?
Conversation
Tell me more about this request? Usually we'd insert something like Historic seems pretty wide, we'd probably want to map the values to new kinds? |
We have created a style similar to OpenTopoMap which also shows palaces, for example this one: https://www.openstreetmap.org/way/38975518 and we didn't have any possibility to filter these buildings because we cannot find these data into vector-datasource. We don't know how to add this correctly into vector-datasource so we tried this. How can I add this properly into vector-datasource? |
@@ -19,7 +19,9 @@ globals: | |||
building_levels: {col: "building:levels"} | |||
building_min_levels: {col: "building:min_levels"} | |||
building_material: {col: "building:material"} | |||
castle_type: {col: castle_type} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better to put into a kind_detail value, with an allowlist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure, I can do it. But I am not sure how. It is a very long time when I was changing it, so I cannot remember how this could be done. Thank you.
height: {col: height} | ||
historic: {col: historic} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What values are present here in historic? Should they be turned into specific kind
values instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure, I can do it. But I am not sure how. It is a very long time when I was changing it, so I cannot remember how this could be done. Thank you.
Add historic and castle_type tags