Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: expose callback function #9032

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 5, 2025

What problem does this PR solve?

Issue Number: ref #8690

What is changed and how does it work?

mockPDServiceDiscovery needs it.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 5, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 10:03:15.554741733 +0000 UTC m=+266067.087153729: ☑️ agreed by lhy1024.
  • 2025-02-05 10:17:26.703456078 +0000 UTC m=+266918.235868076: ☑️ agreed by JmPotato.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.21%. Comparing base (2a1f2dc) to head (80ea931).
Report is 2 commits behind head on master.

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9032      +/-   ##
==========================================
- Coverage   76.26%   76.21%   -0.06%     
==========================================
  Files         466      467       +1     
  Lines       70750    71101     +351     
==========================================
+ Hits        53961    54188     +227     
- Misses      13425    13526     +101     
- Partials     3364     3387      +23     
Flag Coverage Δ
unittests 76.21% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit f6d4ca5 into tikv:master Feb 5, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants