Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: avoid make channel every time (#9009) #9027

Merged
merged 3 commits into from
Jan 26, 2025
Merged

pkg: avoid make channel every time (#9009) #9027

merged 3 commits into from
Jan 26, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9009

What problem does this PR solve?

Issue Number: Close #9004.

What is changed and how does it work?

Only do initialization when there is no channel.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 26, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 26, 2025
Merged
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2025
@rleungx
fix conflicts
5db6051 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-9009-to-release-6.5 branch from f7226c4 to 5db6051 Compare January 26, 2025 08:12
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 26, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 26, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-26 09:21:31.501476632 +0000 UTC m=+604618.832396036: ☑️ agreed by nolouch.
  • 2025-01-26 09:24:44.384484933 +0000 UTC m=+604811.715404337: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit fd9f899 into tikv:release-6.5 Jan 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

@nolouch nolouch nolouch approved these changes

Assignees

@rleungx rleungx

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @nolouch @okJiang @rleungx