Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/tso: init the ticker when TSO Follower Proxy is already enabled #8948

Merged
merged 2 commits into from
Dec 25, 2024
Merged

client/tso: init the ticker when TSO Follower Proxy is already enabled #8948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
535b3c2
Init the ticker when TSO Follower Proxy is already enabled
JmPotato Dec 25, 2024
d99712c
Merge branch 'master' into fix_enable_tso_follower_proxy
ti-chi-bot[bot] Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions client/clients/tso/dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,14 +477,22 @@
)

log.Info("[tso] start tso connection contexts updater")
setNewUpdateTicker := func(ticker *time.Ticker) {
setNewUpdateTicker := func(interval time.Duration) {
if updateTicker.C != nil {
updateTicker.Stop()
}
updateTicker = ticker
if interval == 0 {
updateTicker = &time.Ticker{}
} else {
updateTicker = time.NewTicker(interval)
}
}
// If the TSO Follower Proxy is enabled, set the update interval to the member update interval.
if option.GetEnableTSOFollowerProxy() {
setNewUpdateTicker(sd.MemberUpdateInterval)

Check warning on line 492 in client/clients/tso/dispatcher.go

View check run for this annotation

Codecov / codecov/patch

client/clients/tso/dispatcher.go#L492 

Added line #L492 was not covered by tests
}
// Set to nil before returning to ensure that the existing ticker can be GC.
defer setNewUpdateTicker(nil)
defer setNewUpdateTicker(0)

for {
provider.updateConnectionCtxs(ctx, connectionCtxs)
Expand All @@ -499,13 +507,11 @@
if enableTSOFollowerProxy && updateTicker.C == nil {
// Because the TSO Follower Proxy is enabled,
// the periodic check needs to be performed.
setNewUpdateTicker(time.NewTicker(sd.MemberUpdateInterval))
setNewUpdateTicker(sd.MemberUpdateInterval)
} else if !enableTSOFollowerProxy && updateTicker.C != nil {
// Because the TSO Follower Proxy is disabled,
// the periodic check needs to be turned off.
setNewUpdateTicker(&time.Ticker{})
} else {
continue
setNewUpdateTicker(0)
}
case <-updateTicker.C:
// Triggered periodically when the TSO Follower Proxy is enabled.
Expand Down
Loading