removing spurious warning message in selector #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rishabh_mittal <[email protected]>
crazycs520
approved these changes
Jun 24, 2024
crazycs520
reviewed
Jun 24, 2024
| @@ -914,7 +914,7 @@ func (state *accessFollower) next(bo *retry.Backoffer, selector *replicaSelector | |||
| leaderExhausted := state.IsLeaderExhausted(leader) | |||
| leaderTimeout := leader.deadlineErrUsingConfTimeout | |||
| if len(state.option.labels) > 0 && !state.option.leaderOnly { | |||
| logutil.BgLogger().Warn("unable to find a store with given labels", | |||
| logutil.BgLogger().Debug("unable to find a store with given labels", | |||
There was a problem hiding this comment.
BTW, this log has been removed in the master branch since replica selector v2 was introduced by https://github.com/tikv/client-go/pull/1265/files#diff-0c36d07fbd1fc71c850ff57d323fe12bdf7f2c053ef71b7fec5bb44358f1070dL1003
cfzjywxk
merged commit 01a4f59
into
tikv:tidb-6.5-with-kv-timeout-feature
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1371
This message is printed when a request is tried on all replicas and is failed. Few failures (< 10) per tidb node are expected and it spams the logging for large cluster.