Use numpy build options for CPU optimizations #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this depends on #222 then I think it should merge to that and not the main branch. |
tikk3r
reviewed
Jan 23, 2025
| if [ $MARCH = 'x86-64' ] && [ $MTUNE = 'generic' ]; then | ||
| pip install . -Csetup-args=-Dblas-order=mkl,openblas,blis -Csetup-args=-Dlapack-order=mkl,openblas,lapack | ||
| else | ||
| pip install . -Csetup-args=-Dcpu-baseline="native" -Csetup-args=-Dcpu-dispatch="none" -Csetup-args=-Dblas-order=mkl,openblas,blis -Csetup-args=-Dlapack-order=mkl,openblas,lapack |
There was a problem hiding this comment.
native cannot be used, as these recipes do not "build for local use" as that part of the numpy docs aims for.
|
No worries, just trying to prevent multiple PRs from getting out of sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://numpy.org/doc/stable/reference/simd/build-options.html#i-am-building-numpy-for-my-local-use
This disables CPU dispatching and selects the architecture.
Base branch: #222.