Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused properties from TaskItem interface (#2065) #2066

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed unused properties from TaskItem interface (#2065) #2066

wants to merge 2 commits into from

Conversation

mumtazmumtazfb
Copy link

@mumtazmumtazfb mumtazmumtazfb commented Oct 19, 2024 •
edited
Loading

This pull request resolves issue #2065 by:

  • Removing the following unused properties from the TaskItem interface:
    • hoursSpent
    • completedToday
    • completedTodayIds
    • skippedToday
    • lastCompleted
    • lastSkipped
  • Removing or refactoring the code that was assigning or using these properties.

@vercel Vercel
Copy link

vercel bot commented Oct 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zinzen ✅ Ready (Inspect) Visit Preview Oct 20, 2024 10:20am

@tijlleenders
Copy link
Owner

Thanks @mumtazmumtazfb !

@vinaybadgujar102 I guess there are no refs to these vars?

@vinaybadgujar102
Copy link
Collaborator

@mumtazmumtazfb simply removing the keys from the interface is insufficient. We also need to remove the related code, including instances where the field is assigned or updated

@vinaybadgujar102
Copy link
Collaborator

@mumtazmumtazfb, if you need any help, feel free to ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinaybadgujar102 vinaybadgujar102 Awaiting requested review from vinaybadgujar102

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mumtazmumtazfb @tijlleenders @vinaybadgujar102