Tweaks #3
Merged
Tweaks #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstauffer
requested changes
Jul 12, 2024
| <h2 class="mb-5 text-xl font-bold"> | ||
| <img src="{{ $org->favicon }}" alt="{{ $org->name }}" class="mr-2 inline-block w-9 rounded-lg" /> | ||
| {{ $org->name }} | ||
| <div class="group relative cursor-pointer rounded-lg bg-black/4 p-4 backdrop-blur-lg transition duration-300 hover:bg-black/13 md:p-6 md:pt-5"> |
There was a problem hiding this comment.
Thanks for cleaning this up. There was a lot of cruft left over both from Livewire and also from when the UI was more complicated.
However, in cleaning this up, you can no longer click on the image of the card to get to the page. Can you help with that?
There was a problem hiding this comment.
I think it was because the image comes later in the DOM... I found two fixes for this:
- Move the heading to the bottom and flip it with flexbox (I chose this one)
- Add an extra link that is invisible at the bottom and makes the span inside that one expand
I've chosen the first fix, but let me know if you want me to implement the other one.
|
Thanks Tony! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog