update release note generation #3591
Open
+31
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure milestone is closed before generating release notes - ensure there are no open PRs in the milestone
danudey
requested changes
Nov 6, 2024
| ) | ||
| # Since we only want merged PRs, raise an error if there are none. | ||
| if len(merged_issues) == 0: | ||
| raise ReleaseNoteError(f"no issues found for milestone {m.title}") |
There was a problem hiding this comment.
Technically we have had operator releases in the past which have no release-note-required PRs, so technically having no merged issues isn't necessarily an error - but we should probably call it out to the user to ensure they can double-check the results and/or add a disclaimer for users.
This was the case for v1.34.5, as an example.
There was a problem hiding this comment.
In that case, we should not be using this tooling to generate release notes.
There was a problem hiding this comment.
It still generates the outline for the release notes, so it's still valuable to run.
danudey
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.