Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update operator to enable LoadBalancer kube-controller #3490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update operator to enable LoadBalancer kube-controller #3490

wants to merge 2 commits into from

Conversation

MichalFupso
Copy link
Contributor

Description

Enable operator to start LoadBalancer kube-controller

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@MichalFupso MichalFupso requested a review from a team as a code owner September 11, 2024 19:04
@marvin-tigera marvin-tigera added this to the v1.36.0 milestone Sep 11, 2024
@radTuti radTuti modified the milestones: v1.36.0, v1.36.1 Oct 28, 2024
@caseydavenport caseydavenport modified the milestones: v1.36.1, v1.37.0 Oct 28, 2024
caseydavenport
caseydavenport approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we'll need to wait for the feature PR to merge first (sorry for delay on that one.....)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.37.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalFupso @caseydavenport @radTuti @marvin-tigera