Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calico apiserver improvements #3481

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tamas-Biro1
Copy link
Contributor

@Tamas-Biro1 Tamas-Biro1 commented Aug 29, 2024

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch 3 times, most recently from 4ee9d6e to 57ec0f3 Compare August 29, 2024 07:46
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts and use case requests around these changes.

api/v1/apiserver_types.go Outdated Show resolved Hide resolved
api/v1/apiserver_types.go Outdated Show resolved Hide resolved
api/v1/apiserver_types.go Outdated Show resolved Hide resolved
api/v1/apiserver_types.go Outdated Show resolved Hide resolved
@radTuti radTuti modified the milestones: v1.36.0, v1.36.1 Oct 28, 2024
@caseydavenport caseydavenport modified the milestones: v1.36.1, v1.37.0 Oct 28, 2024
@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch 3 times, most recently from dca69d9 to 657730b Compare November 5, 2024 16:28
@Tamas-Biro1 Tamas-Biro1 marked this pull request as ready for review November 5, 2024 16:31
@Tamas-Biro1 Tamas-Biro1 requested a review from a team as a code owner November 5, 2024 16:31
@Tamas-Biro1 Tamas-Biro1 requested a review from tmjd November 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants