Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive calibrator - new api #179

Open
wants to merge 2 commits into
base: tier4/universe
Choose a base branch
from

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Jul 19, 2024

Description

This should be reviewed after the documentation gets merged (and rebased before merged)
It is has little to no priority compared with other calibration tools tasks

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@vividf vividf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Test that the sensor_calibration_manager is able to launch the calibrator in the default project.

@knzo25
Copy link
Collaborator Author

knzo25 commented Aug 26, 2024

*Tested
You need to test that you can calibrate and that that the output is correct (i.e, that if you publish the output Tf it gives you the result you want)

@knzo25 knzo25 requested a review from vividf August 26, 2024 21:33
@knzo25
Copy link
Collaborator Author

knzo25 commented Aug 30, 2024

@vividf

@vividf
Copy link
Contributor

vividf commented Aug 30, 2024

@knzo25 got it!

@knzo25
Copy link
Collaborator Author

knzo25 commented Sep 11, 2024

@vividf ?
You can use the data from the lidartag method, or the one from the related issue

Base automatically changed from feature/new_api_documentation to tier4/universe September 24, 2024 12:33
…d fixed some bugs

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@knzo25 knzo25 force-pushed the feat/interactive_calibrator_new_api branch from 1cf3e2b to 357dced Compare September 24, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants