Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extrinsic_tag_based_base_calibrator): fixed viz callback in case some detections get lost #146

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Dec 1, 2023

Description

fixed viz callback in case some detections get lost due to inconsistencies

Related links

TIER IV INTERNAL LINK

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@knzo25 knzo25 requested a review from yabuta December 1, 2023 05:32
@knzo25 knzo25 self-assigned this Dec 1, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b0153ee) 0.95% compared to head (6b24dde) 0.00%.
Report is 3 commits behind head on tier4/universe.

Files Patch % Lines
...brator/src/extrinsic_tag_based_base_calibrator.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##           tier4/universe    #146      +/-   ##
=================================================
- Coverage            0.95%   0.00%   -0.96%     
=================================================
  Files                 269      21     -248     
  Lines               20908    2425   -18483     
  Branches              387       0     -387     
=================================================
- Hits                  200       0     -200     
+ Misses              20551    2425   -18126     
+ Partials              157       0     -157     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25 knzo25 merged commit 396c3ac into tier4/universe Dec 4, 2023
6 of 10 checks passed
@knzo25 knzo25 deleted the fix/extrinsic_tag_based_calibrator_viz branch December 4, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants