Skip to content

Commit

Permalink
NEWS and CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Apr 18, 2021
1 parent fac2557 commit 4a56ae8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 24 deletions.
22 changes: 6 additions & 16 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,12 @@

# tibble 3.1.1

- Same as previous version.


# tibble 3.1.0.9001

- `num()` and `char()` are reexported from pillar (#880).
- `tribble()` and `frame_matrix()` give an error if values are named (#871, @lorenzwalthert).
- Document `cli.num_colors` option (#410).
- Fix `new_tibble()` examples for compatibility with pillar 1.6.0.


# tibble 3.1.0.9000

- Internal changes only.


# tibble 3.1.0

## Bug fixes
Expand Down Expand Up @@ -142,19 +132,19 @@
- Subset assignment ("subassignment") and also subsetting has become stricter. Symptoms:

- Error: No common type for ...

- Error: Assigned data `...` must be compatible with ...

- `i` must have one dimension, not 2

- Error: Lossy cast from ... to ...

The "invariants" article at https://tibble.tidyverse.org/dev/articles/invariants.html describes the invariants that the operations follow in tibble, and the most important differences to data frames. We tried to make subsetting and subassignment as safe as possible, so that errors are caught early on, while introducing as little friction as possible.

- List classes are no longer automatically treated as vectors. Symptoms:

- Error: All columns in a tibble must be vectors

- Error: Expected a vector, not a `...` object

If you implement a class that wraps a list as S3 vector, you need to include `"list"` in the class:
Expand Down Expand Up @@ -321,7 +311,7 @@ To improve compatibility with existing code, breaking changes were reduced to a
- `as_tibble.data.frame()` (and also `as_tibble.matrix()`) strip row names by default. Code that relies on tibbles keeping row names now will see:
- a different result when calling `rownames()` or `row.names()`,
- rows full of `NA` values when subsetting rows with with a character vector, e.g. `as_tibble(mtcars)["Mazda RX4", ]`.
Call `pkgconfig::set_config("tibble::rownames", NA)` to revert to the old behavior of keeping row names. Packages that import _tibble_ can call `set_config()` in their `.onLoad()` function (#114).
- `as_tibble()` drops extra classes, in particular `as_tibble.grouped_df()` now removes grouping (#535).
Expand Down Expand Up @@ -357,9 +347,9 @@ To improve compatibility with existing code, breaking changes were reduced to a
- `NA`: keep row names,
- A string: the name of the new column that will contain the existing row names,
which are no longer present in the result.

The old default can be restored by calling `pkgconfig::set_config("tibble::rownames", NA)`, this also works for packages that import _tibble_.

- `new_tibble()` and `as_tibble()` now also strip the `"dim"` attribute from columns that are one-dimensional arrays. (`tibble()` already did this before.)

- Internally, all `as_tibble()` implementation forward all extra arguments and `...` to `as_tibble.list()` where they are handled. This means that the common `.rows` and `.name_repair` can be used for all inputs. We suggest that your implementations of this method do the same.
Expand Down
12 changes: 4 additions & 8 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,11 @@ tibble 3.1.1
## R CMD check results

- [x] Checked locally, R 4.0.5
- [ ] Checked on CI system, R 4.0.5
- [ ] Checked on win-builder, R devel

Check the boxes above after successful execution and remove this line. Then run `fledge::release()`.
- [x] Checked on CI system, R 4.0.5
- [x] Checked on win-builder, R devel

## Current CRAN check results

- [x] Checked on 2021-04-18, problems found: https://cran.r-project.org/web/checks/check_results_tibble.html
- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64-gcc10-UCRT
- [ ] ERROR: r-devel-windows-ix86+x86_64

Check results at: https://cran.r-project.org/web/checks/check_results_tibble.html
- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64-gcc10-UCRT: LazyData field removed
- [x] ERROR: r-devel-windows-ix86+x86_64: False positive

0 comments on commit 4a56ae8

Please sign in to comment.