transition expect_error() for snowflake backend
#1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ...to snapshot when testing the error message * ...to classed error when testing an error from another package or an error thrown from a widely-used helper * ...to `expect_no_error()` (or no test) when `regex = NA` * Analogous story for `expect_warning()` and `expect_message()`.
hadley
approved these changes
Oct 28, 2024
R/utils-check.R
Outdated
| @@ -144,7 +144,7 @@ check_unsupported_arg <- function(x, | |||
|
|
|||
| msg <- c(msg, i = allow_msg) | |||
| } | |||
| cli_abort(msg, call = call) | |||
| cli_abort(msg, call = call, class = "unsupported_arg_error") | |||
There was a problem hiding this comment.
Maybe include the arg in the error object too?
I'd make the class start with dbplyr_. I'm have mixed feelings about including error in the class name (since it seems redundant) but I see that rlang includes it, so best to be conssitent?
There was a problem hiding this comment.
@DavisVaughan suggests using dbplyr_error_... to match vctrs.
| ) | ||
| expect_snapshot( | ||
| error = TRUE, | ||
| test_translate_sql(difftime(start_date, end_date, tz = "UTC", units = "days")) |
There was a problem hiding this comment.
expectg_error(class = "unsupported_arg_error")?
There was a problem hiding this comment.
Woops, should have called this out in a self-review—these two lines transition from expect_error() to expect_snapshot() for one-off, unclassed errors where we're interested in testing the message specifically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the first checkbox in #1546 but does not close; a demo of what that PR would look like for all backends.
For snowflake, transition
expect_error():expect_no_error()(or no test) whenregex = NAexpect_warning()andexpect_message().