Shim sql_escape_ident() for RMySQL #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it doesn't appear to handle SQL objects. Fixes childesr revdep failure.
Closed
mgirlich
approved these changes
Mar 1, 2024
|
Why doe the checks fail? I couldn't reproduce this locally... |
|
Hmmm, it's because the example doesn't have RMySQL loaded. I could fix that, but maybe it's better to remove the accidental hard dependency I added when simulating MySQL? (TBH I'm actually surprised that loading RMySQL appears to fix the problem because we're passing an S3 object to an S4 generic) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it doesn't appear to handle SQL objects. Fixes childesr revdep failure.