Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add escaping for Snowflake interval functions #1350

Closed
wants to merge 3 commits into from
Closed

add escaping for Snowflake interval functions #1350

wants to merge 3 commits into from

Conversation

fh-mthomson
Copy link
Contributor

@fh-mthomson fh-mthomson commented Aug 10, 2023 •
edited
Loading

Closes #1351 (Solution 1, just for Snowflake)

@fh-mthomson fh-mthomson mentioned this pull request Aug 10, 2023
Closed
@mgirlich
Copy link
Collaborator

Closed in favour of #1352.
I tried to find and fix all the new issues after switching to glue_sql2(). This also has the easier way of simply using {.val x} instead of manually escaping 😄

@mgirlich mgirlich closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: migrating from build_sql() to glue_sql2() lost escaping
2 participants
@fh-mthomson @mgirlich