Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS SQL Fix Translation of Unordered row_number() #1316

Closed
wants to merge 3 commits into from

Conversation

ejneer
Copy link
Contributor

@ejneer ejneer commented Jun 28, 2023

Fixes row_number issue of #1233

@ejneer
Copy link
Contributor Author

ejneer commented Jun 28, 2023

Looks like the failing test is the result of the recent change on r-devel to warn about unaliased Rd files mentioned in #1312

mf %>% mutate(rn = row_number())
Output
<SQL>
SELECT `df`.*, ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS `rn`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm amazed this works. This just feels so wrong 😄

@mgirlich
Copy link
Collaborator

Thanks for the PR. I'm actually not quite sure whether we actually want to support row_number() without any input.

@mgirlich
Copy link
Collaborator

Closed by #1331.

@mgirlich mgirlich closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants