Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glue_sql2() uses #1352

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix glue_sql2() uses #1352

merged 3 commits into from
Aug 16, 2023

Conversation

mgirlich
Copy link
Collaborator

Fixes #1351.

@mgirlich mgirlich mentioned this pull request Aug 11, 2023
Closed
@fh-mthomson
Copy link
Contributor

I've confirmed this PR, combined with #1331 now has our internal package test suites passing for Snowflake.

It was great to learn more about glue_sql2().

Thank you, @mgirlich for the continued support - looking forward to the next release!

@mgirlich mgirlich merged commit ba01847 into main Aug 16, 2023
13 of 14 checks passed
@mgirlich mgirlich deleted the fix-glue_sql2-uses branch August 16, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: migrating from build_sql() to glue_sql2() lost escaping
2 participants
@mgirlich @fh-mthomson