Deprecate tbl_sql(check_from)

NAMESPACE

@@ -678,6 +678,7 @@ importFrom(dplyr,ungroup)
 importFrom(dplyr,union)
 importFrom(dplyr,union_all)
 importFrom(glue,glue)
+importFrom(lifecycle,deprecated)
 importFrom(magrittr,"%>%")
 importFrom(methods,initialize)
 importFrom(pillar,align)

NEWS.md

@@ -22,6 +22,8 @@
 
   * If you accidentally pass a named vector to any of the database identifer
     functions, those names will be automatically stripped (#1404).
+
+  * `tbl_sql(check_from)` is now deprecated.
 
 * When dbplyr creates an index on a table in a schema (e.g. `schema.table`), 
   it now only includes the table name in the index name, not the schema name.

R/dbplyr.R

@@ -7,5 +7,6 @@
 #' @import DBI
 #' @importFrom tibble tibble as_tibble
 #' @importFrom magrittr %>%
+#' @importFrom lifecycle deprecated
 #' @keywords internal
 "_PACKAGE"

R/tbl-sql.R

@@ -12,11 +12,20 @@
 #'   to avoid retrieving them from the database.
 #'   Mainly useful for better performance when creating
 #'   multiple `tbl` objects.
-#' @param check_from Check if `from` is likely misspecified SQL or a table in a schema.
-tbl_sql <- function(subclass, src, from, ..., vars = NULL, check_from = TRUE) {
+#' @param check_from `r lifecycle::badge("deprecated")`
+tbl_sql <- function(subclass,
+                    src,
+                    from,
+                    ...,
+                    vars = NULL,
+                    check_from = deprecated()) {
   # Can't use check_dots_used(), #1429
   check_character(vars, allow_null = TRUE)
 
+  if (lifecycle::is_present(check_from)) {
+    lifecycle::deprecate_warn("2.5.0", "tbl_sql(check_from)")
+  }
+
   from <- as_table_source(from, con = src$con)
   vars <- vars %||% dbplyr_query_fields(src$con, from)