Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark rolling_origin() as superseded #524

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Mark rolling_origin() as superseded #524

merged 7 commits into from
Sep 4, 2024

Conversation

nmercadeb
Copy link
Contributor

Closes #448

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Could you also add the corresponding badge to the documentation as laid out here: https://lifecycle.r-lib.org/articles/communicate.html#supersede-a-function

@hfrick
Copy link
Member

hfrick commented Aug 23, 2024

@nmercadeb Thank you for the edits! I'm just dropping in quickly to say that I'm OOO until the week after next but will get to this after my return.

@hfrick hfrick changed the title deprecate rolling_origin Mark rolling_origin() as superseded Sep 4, 2024
@hfrick hfrick merged commit 5c8d38e into tidymodels:main Sep 4, 2024
12 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark rolling_origin() as superseded
3 participants