fix(android): fix global header/footer title in ListView #14175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1ga
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Nice PR 👍
Tested:
- TableView/ListView mocha tests run without issues (reminder for https://github.com/tidev/titanium-sdk/pull/14158/files 😉 ) ✔️
- test code from fix(android): fix global header/footer title in ListView #14160 runs fine ✔️
- app without header/footer views still looks the same ✔️
- kitchensink_v2 listview examples work fine ✔️
don't have any app that is using complex header/footer views so I can just rely on the example projects/code.
Most of the code changes are due to the optimizing (well done 👍 ), the "reset layout" parts should be the main fix for the issue and that works fine.
hansemannn
pushed a commit
that referenced
this pull request
Feb 3, 2025
* fix(android): fix ListView's header and footer title alignment * fix(android): set title attributes only when required * chore: reuse same code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing this PR
headerTitleandfooterTitlealignment.headerTitle/footerTitleattributes only when corresponding property is available.