Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lowpass filter lfo #1246

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

added lowpass filter lfo #1246

wants to merge 3 commits into from

Conversation

thckr
Copy link

@thckr thckr commented Jan 18, 2025

added lowpass filter lfo

note("g1").s("sawtooth").lpf(400).lplfo("<1 2 3 4>")

@daslyfe
Copy link
Collaborator

daslyfe commented Jan 21, 2025

We have a method for continuous modulation without using "real" lfo nodes. See the phaser for an example! The only thing holding back from implementing them everywhere is that we haven't discovered a great way yet to describe the modulation in strudel code to a general implementation

@felixroos felixroos added the v1.2 label Jan 24, 2025
@felixroos
Copy link
Collaborator

We have a method for continuous modulation without using "real" lfo nodes. See the phaser for an example! The only thing holding back from implementing them everywhere is that we haven't discovered a great way yet to describe the modulation in strudel code to a general implementation

i think it would still be desirable to have a dedicated filter lfo control. we could refactor the definition later if we find a more general approach to lfos. to me it would be huge to be able to write .lplfo(4) and get that wobbly filter

@daslyfe
Copy link
Collaborator

daslyfe commented Feb 1, 2025

We have a method for continuous modulation without using "real" lfo nodes. See the phaser for an example! The only thing holding back from implementing them everywhere is that we haven't discovered a great way yet to describe the modulation in strudel code to a general implementation

i think it would still be desirable to have a dedicated filter lfo control. we could refactor the definition later if we find a more general approach to lfos. to me it would be huge to be able to write .lplfo(4) and get that wobbly filter

sounds good! we can use the lfo worklet for continuous modulation, and also use the same language we used for the phaser possibly? https://github.com/tidalcycles/strudel/blob/main/packages/superdough/superdough.mjs#L196C10-L196C19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants