Add bank aliasing and case insensitivity #1245

TodePond · 2025-01-18T11:13:05Z

What is this pull request?

This is a spicy pull request that adds an aliasBank function. It lets you create an alias for any bank of sounds.

This pull request also adds lots of aliases by defaults. For example, "TR909" is an alias for "RolandTR909". Check out the aliases JSON file for all the aliases.

This pull request also removes cases-sensitivity from ALL SOUNDS. This is a big breaking change.
If this isn't wanted at this point, let's remove it and discuss within a future pull request.

Release notes

Added the aliasBank function that lets you create aliases for banks.
Added lots of default aliases for drum machine banks, eg: "TR909" for "RolandTR909".
Sounds are now case insensitive.

Future work

Make the sounds interface nicer and easier.
Move the JSON hosted elsewhere into the strudel repo (see comments).

.prettierignore

yaxu · 2025-01-18T20:11:36Z

How does this look in the sound browsing interface?

I find the sound bank implementation difficult to teach in workshops, especially where 'sounds' are already a sample set (via n) and 'banks' are a level above but don't appear that way in the sound browser. Improving this is probably out of scope for this PR but we should try not to make things more confusing.

Agreed the shorter names are better and would like to deprecate the long ones. Perhaps we could also go for all lowercase with the short versions.

felixroos · 2025-01-18T20:17:42Z

How does this look in the sound browsing interface?

I find the sound bank implementation difficult to teach in workshops, especially where 'sounds' are already a sample set (via n) and 'banks' are a level above but don't appear that way in the sound browser. Improving this is probably out of scope for this PR but we should try not to make things more confusing.

Agreed the shorter names are better and would like to deprecate the long ones. Perhaps we could also go for all lowercase with the short versions.

yes the sound tab needs renovation!

another hot take hot take hot take: we could make use of the fact that all drum samples get new names and give a little tlc to the samples (e.g. 808 defaults are weird) + maybe mix them differently (hihats quieter etc..) ? if we do it now, before people use them, we won't get a breaking change..

yaxu · 2025-01-18T20:20:54Z

another hot take hot take hot take: we could make use of the fact that all drum samples get new names and give a little tlc to the samples (e.g. 808 defaults are weird) + maybe mix them differently (hihats quieter etc..) ? if we do it now, before people use them, we won't get a breaking change..

Yes that's a nice idea! Then every time we have to type RolandTR808 we're more motivated to do some sample mastering..

yaxu · 2025-01-18T20:56:46Z

Strictly speaking Visco probably isn't a manufacturer name because Visco Space Drum probably never existed https://gearspace.com/board/electronic-music-instruments-and-electronic-music-production/390269-visco-space-drum.html

TodePond · 2025-01-18T22:12:42Z

How does this look in the sound browsing interface?

good point, i hadn't thought of that. thanks for pointing it out.

this pr could probably filter out one set of names in the menu, and a future pull request could improve the overall ux of the drum sound menu

Perhaps we could also go for all lowercase with the short versions.

even better could be to make it case insensitive?

Visco Space Drum probably never existed

woah!

I'm not wedded to any choices here, will happily merge or make any changes no questions asked

just a heads up to both of you that the shortened list misses off a couple that i couldn't figure out how to shorten

felixroos · 2025-01-22T01:03:41Z

an alternative take on this would be to handle aliases after the json has been processed. here's an example aliasBank function . this would save file size + it's usable with from disk autogenerated strudel.json files á la @strudel/sampler (based on discussion in strudel-innards)

felixroos · 2025-01-24T09:24:00Z

@TodePond do you want to add the aliasBank function above? would be nice to get this into the next version

TodePond · 2025-01-24T09:39:53Z

sure thing! do you mean just the function? (for people to use)

or also all the aliases? (called with the function)

hope that makes sense

felixroos · 2025-01-24T09:44:02Z

sure thing! do you mean just the function? (for people to use)

or also all the aliases? (called with the function)

hope that makes sense

i'd say also the aliases called with the function. maybe make them lowercase as well? there might also be a way to improve / simplify it for setting up multiple aliases at once but not super important

TodePond · 2025-01-24T13:45:49Z

yes!

when are you planning / hoping to do the release by the way?

felixroos · 2025-01-24T14:15:22Z

yes!

when are you planning / hoping to do the release by the way?

soonish.. when the next wave of PRs is merged, but not sure when that will be exactly..

TodePond · 2025-01-26T16:54:29Z

packages/repl/prebake.mjs

@@ -21,6 +21,9 @@ export async function prebake() {
  );
  // load samples
  const ds = 'https://raw.githubusercontent.com/felixroos/dough-samples/main/';
+
+  // TODO: move this onto the strudel repo
+  const ts = 'https://raw.githubusercontent.com/todepond/samples/main/';


https://github.com/TodePond/samples/blob/main/tidal-drum-machines-alias.json

TodePond · 2025-01-26T16:55:15Z

packages/repl/prebake.mjs

@@ -36,6 +39,8 @@ export async function prebake() {
    samples(`${ds}/EmuSP12.json`),
    samples(`${ds}/vcsl.json`),
  ]);
+
+  aliasBank(`${ts}/tidal-drum-machines-alias.json`);


what's the bet way to try out the repl? i only checked the web version works (with pnpm dev)

i test with this https://github.com/tidalcycles/strudel/blob/main/examples/buildless/web-component-no-iframe.html replacing the unpkg url with the locally built repl package (run pnpm build in the repl folder)

TodePond · 2025-01-26T16:55:45Z

packages/superdough/superdough.mjs

+      return aliasBankMap({ [args[0]]: args[1] });
+    default:
+      throw new Error('aliasMap expects 1 or 2 arguments, received ' + args.length);
+  }


if theres a better place for this function to live lemme know and i'll move it

TodePond · 2025-01-26T16:56:09Z

website/public/tidal-drum-machines-alias.json

+  "RolandTR707": "TR707",
+  "RolandTR727": "TR727",
+  "RolandTR808": "TR808",
+  "RolandTR909": "TR909",


kinda wanna add "909" as another alias but its a slippery slope

website/public/tidal-drum-machines-alias.json

TodePond · 2025-01-26T16:56:36Z

website/public/tidal-drum-machines-alias.json

+  "SimmonsSDS5": "SDS5",
+  "SoundmastersR88": "R88",
+  "UnivoxMicroRhythmer12": "MicroRhythmer12",
+  "ViscoSpaceDrum": "SpaceDrum",


its real my neighbour told me

TodePond · 2025-01-26T16:57:08Z

ready for review now!
Read the pull request description for the current changes.
left some comments too

add shortened bank names

45fffa5

TodePond commented Jan 18, 2025

View reviewed changes

.prettierignore Show resolved Hide resolved

felixroos mentioned this pull request Jan 22, 2025

convert to issues pastagang/nudel#54

Open

17 tasks

felixroos added the v1.2 label Jan 24, 2025

TodePond added 3 commits January 26, 2025 11:28

Merge remote-tracking branch 'origin/main' into lu/add-drum-suffixes

4f6e38f

add aliasbank function

e660449

fix repeated calls

a2c896f

TodePond marked this pull request as draft January 26, 2025 12:38

TodePond added 5 commits January 26, 2025 14:30

improve function

710da1d

set by value so it actually updates

90fe4d3

revert manual bank aliases

234beff

fix and overload

7222c29

add docs and allow arrays of aliases

fd68ad9

TodePond changed the title ~~[hot take] Add shortened bank names~~ Add bank aliasing and case insensitivity Jan 26, 2025

TodePond added 4 commits January 26, 2025 16:28

add comments and case insensitivity

f362f1c

allow aliasing via a path

5d3778f

setup default aliasing

7e1c6c1

add more aliases

c9bdfe5

TodePond marked this pull request as ready for review January 26, 2025 16:53

TodePond commented Jan 26, 2025

View reviewed changes

Update website/public/tidal-drum-machines-alias.json

d192201

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add bank aliasing and case insensitivity #1245

Add bank aliasing and case insensitivity #1245

TodePond commented Jan 18, 2025 •

edited

Loading

yaxu commented Jan 18, 2025 •

edited

Loading

felixroos commented Jan 18, 2025

yaxu commented Jan 18, 2025

yaxu commented Jan 18, 2025 •

edited

Loading

TodePond commented Jan 18, 2025

felixroos commented Jan 22, 2025 •

edited

Loading

felixroos commented Jan 24, 2025

TodePond commented Jan 24, 2025

felixroos commented Jan 24, 2025

TodePond commented Jan 24, 2025

felixroos commented Jan 24, 2025

TodePond Jan 26, 2025

TodePond Jan 26, 2025

felixroos Jan 26, 2025 •

edited

Loading

TodePond Jan 26, 2025

TodePond Jan 26, 2025

TodePond Jan 26, 2025

TodePond commented Jan 26, 2025

Add bank aliasing and case insensitivity #1245

Are you sure you want to change the base?

Add bank aliasing and case insensitivity #1245

Conversation

TodePond commented Jan 18, 2025 • edited Loading

What is this pull request?

Release notes

Future work

yaxu commented Jan 18, 2025 • edited Loading

felixroos commented Jan 18, 2025

yaxu commented Jan 18, 2025

yaxu commented Jan 18, 2025 • edited Loading

TodePond commented Jan 18, 2025

felixroos commented Jan 22, 2025 • edited Loading

felixroos commented Jan 24, 2025

TodePond commented Jan 24, 2025

felixroos commented Jan 24, 2025

TodePond commented Jan 24, 2025

felixroos commented Jan 24, 2025

TodePond Jan 26, 2025

Choose a reason for hiding this comment

TodePond Jan 26, 2025

Choose a reason for hiding this comment

felixroos Jan 26, 2025 • edited Loading

Choose a reason for hiding this comment

TodePond Jan 26, 2025

Choose a reason for hiding this comment

TodePond Jan 26, 2025

Choose a reason for hiding this comment

TodePond Jan 26, 2025

Choose a reason for hiding this comment

TodePond commented Jan 26, 2025

TodePond commented Jan 18, 2025 •

edited

Loading

yaxu commented Jan 18, 2025 •

edited

Loading

yaxu commented Jan 18, 2025 •

edited

Loading

felixroos commented Jan 22, 2025 •

edited

Loading

felixroos Jan 26, 2025 •

edited

Loading