Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdeModulePkg: Add Segment info promt for PCIe enumeration. #10645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xunfengd
Copy link

https://bugzilla.tianocore.org/show_bug.cgi?id=4783

For platforms supporting multi-segments, the edk2 would only print Bus,Dev,Func info but ignore the segments info which would cause duplicate device scanning info.

Cc: Liming Gao [email protected]
Cc: Ray Ni [email protected]

Reviewed-by: Liming Gao [email protected]
Reviewed-by: Ray Ni [email protected]

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

https://bugzilla.tianocore.org/show_bug.cgi?id=4783

For platforms supporting multi-segments, the edk2 would only print
Bus,Dev,Func info but ignore the segments info which would cause duplicate
device scanning info.

Cc: Liming Gao <[email protected]>
Cc: Ray Ni <[email protected]>
Signed-off-by: Darren Dong <[email protected]>
Reviewed-by: Liming Gao <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
@xunfengd
Copy link
Author

Hi @niruiyu and @lgao4,
The previous pr is out of date, so re-submit a new PR. This PR is only for uart log output enhancement without function level defect. Could u help to review it ? Thanks!

@xunfengd xunfengd marked this pull request as draft January 19, 2025 14:32
@xunfengd xunfengd marked this pull request as ready for review January 20, 2025 02:04
@lgao4
Copy link
Contributor

lgao4 commented Feb 2, 2025

Hi @niruiyu and @lgao4, The previous pr is out of date, so re-submit a new PR. This PR is only for uart log output enhancement without function level defect. Could u help to review it ? Thanks!

Could you fix CI failure first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants