MdePkg: Update BASE_CR macro in Base.h for a Coverity error #10556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity is a static analysis tool. It detects the macro as an error (case to incompatible type, cert_exp39_c_violation). The update resolves the error and supports compliance with the static tool.
For example,
MdeModulePkg\Universal\HiiDatabaseDxe\Database.c
Code :
Entry = BASE_CR (Link, VARSTORAGE_DEFAULT_DATA, Entry);
Coverity Error :
(3) Event cast_to_incompatible_type: Casting "(CHAR8 *)Link - 0ULL" of type "CHAR8 *" to incompatible type "VARSTORAGE_DEFAULT_DATA *".
(4) Event assign: Assigning: "Entry" = "(VARSTORAGE_DEFAULT_DATA *)((CHAR8 *)Link - 0ULL)".
Also see events: [cert_exp39_c_violation]
How This Was Tested
The update has been tested and verified on AMD EDKII bios. With it, the Coverity error is resolved.
Integration Instructions
N/A