Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockito-4.0.0-support #28

Open
wants to merge 1 commit into
base: 3.0-master
Choose a base branch
from

Conversation

iamAnna
Copy link

@iamAnna iamAnna commented Jun 17, 2022

Hello thymeleaf-testing maintainers,
I'm adding a PR here hoping this is a simple update (and possible patch release), but as someone not involved in the project I could be totally off base, not considering things already in the pipeline, etc.
I use this testing library in a couple of work projects, and am blocked from updating to Spring-Boot 2.6.5 due to the deprecated org.mockito.Matchers references. See open issue: Support for Mockito 4 - #23

I did read through the contribution docs, but please correct me if I missed something. Thank you!


  • Update version of mockito from 1.10.19 to 4.0.0. Replace use of deprecated mockito Matchers with ArgumentMatchers.

…cated mockito Matchers with ArgumentMatchers.
@rizwan-ishtiaq
Copy link

what is the show stoper for it PR?

@iamAnna
Copy link
Author

iamAnna commented Jun 29, 2023

what is the show stoper for it PR?

I’m not sure I understand what you’re asking. I’m unable to merge or add reviewers since I don’t have write access to this repo.
If I misunderstood your question, could you please clarify? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants