Fix if check before setting is_valid=true in validate.yml (Fixes #49)

thunderbird · Dec 16, 2024 · de5d0a6 · de5d0a6
1 parent 3c74806
commit de5d0a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/convert.yml b/.github/workflows/convert.yml
@@ -50,8 +50,10 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Check for validation success and file changes
+        env:
+          IS_VALID: ${{ needs.validate_json.outputs.is_valid }}
         run: |
-          if [ "${{ needs.validate_json.outputs.is_valid }}" != "true" ]; then
+          if [ ${IS_VALID} != "true" ]; then
             echo "JSON is not valid. Skipping commit."
             echo "NO_COMMIT=true" >> $GITHUB_ENV
           elif git diff --quiet; then

diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -53,5 +53,5 @@ jobs:
 
       - name: Save state
         id: save_state
-        if: steps.validate_json.conclusion == 'success'
+        if: ${{ success() }}
         run: echo "is_valid=true" >> $GITHUB_OUTPUT