Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brand name in "Support Thunderbird" settings list item #8388

Merged
merged 1 commit into from
Oct 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import androidx.navigation.fragment.findNavController
import androidx.recyclerview.widget.ItemTouchHelper
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import app.k9mail.core.common.provider.AppNameProvider
import app.k9mail.core.common.provider.BrandNameProvider
import app.k9mail.core.featureflag.FeatureFlagKey
import app.k9mail.core.featureflag.FeatureFlagProvider
import app.k9mail.core.ui.legacy.designsystem.atom.icon.Icons
Expand All @@ -41,7 +41,7 @@ import app.k9mail.feature.settings.importing.R as SettingsImportR
class SettingsListFragment : Fragment(), ItemTouchCallback {
private val viewModel: SettingsViewModel by viewModel()
private val fundingManager: FundingManager by inject()
private val appNameProvider: AppNameProvider by inject()
private val brandNameProvider: BrandNameProvider by inject()
private val featureFlagProvider: FeatureFlagProvider by inject()

private lateinit var itemAdapter: ItemAdapter<GenericItem>
Expand Down Expand Up @@ -154,7 +154,7 @@ class SettingsListFragment : Fragment(), ItemTouchCallback {
featureFlagProvider.provide(FeatureFlagKey("funding_google_play"))
.onEnabled {
addIntent(
text = getString(R.string.settings_list_action_support, appNameProvider.appName),
text = getString(R.string.settings_list_action_support, brandNameProvider.brandName),
icon = Icons.Outlined.Favorite,
intent = FeatureLauncherActivity.getIntent(
context = requireActivity(),
Expand All @@ -166,7 +166,7 @@ class SettingsListFragment : Fragment(), ItemTouchCallback {

FundingType.LINK -> {
addUrlAction(
text = getString(R.string.settings_list_action_support, appNameProvider.appName),
text = getString(R.string.settings_list_action_support, brandNameProvider.brandName),
url = getString(R.string.funding_url),
icon = Icons.Outlined.Favorite,
)
Expand Down