Add confirm delete in trash #7723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beradeep
force-pushed
the
add-confirm-delete-in-trash
branch
from
6e96edf
to
b5cc832
Compare
|
@beradeep Thanks for working on this. I've added a comment to issue #7707 adding details about how I think this feature should behave. |
|
@cketti Shall I continue working on it, and try to incorporate the suggestions? |
That would be great. Please note that messages can also be deleted from places other than the message list. Looking at references to |
|
This turned out to be more complex than I initially thought (see #7731). I think it'll be a while before our code is in a shape where we can easily implement this feature. Closing this pull request. The feature request issue remains open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7707