Apply suggestions from review

threema-ch · May 14, 2024 · a8c260d · a8c260d
1 parent 3d7cdb8
commit a8c260d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/src/errors.rs b/src/errors.rs
@@ -14,7 +14,7 @@ pub enum PushRelayError {
     #[error("Reqwest error: {0}")]
     Reqwest(#[from] ReqwestError),
 
-    #[error("{reason}: {source}")]
+    #[error("I/O error: {reason}: {source}")]
     IoError {
         reason: &'static str,
         source: std::io::Error,

diff --git a/src/influxdb.rs b/src/influxdb.rs
@@ -92,10 +92,7 @@ impl Influxdb {
         }
     }
 
-    async fn log<B>(&self, body: B) -> InfluxdbResult
-    where
-        B: Into<Body>,
-    {
+    async fn log(&self, body: impl Into<Body>) -> InfluxdbResult {
         let body: Body = body.into();
 
         // Send request

diff --git a/src/push/hms.rs b/src/push/hms.rs
@@ -42,7 +42,7 @@ pub struct HmsStateConfig {
 type SharedHmsConfig = Arc<HmsStateConfig>;
 
 impl HmsStateConfig {
-    pub fn new() -> SharedHmsConfig {
+    pub fn new_shared() -> SharedHmsConfig {
         let login_endpoint = Cow::Borrowed("https://oauth-login.cloud.huawei.com");
         let push_endpoint = Cow::Borrowed("https://push-api.cloud.huawei.com");
         Arc::new(Self {

diff --git a/src/server.rs b/src/server.rs
@@ -141,7 +141,7 @@ pub async fn serve(
         apns_client_prod: apns_client_prod.clone(),
         apns_client_sbox: apns_client_sbox.clone(),
         hms_contexts: hms_contexts.clone(),
-        hms_config: HmsStateConfig::new(),
+        hms_config: HmsStateConfig::new_shared(),
         threema_gateway_client: threema_gateway_client.clone(),
         threema_gateway_private_key: threema_gateway_private_key.clone(),
         threema_gateway_config: threema_gateway.clone(),