Refactor Connect wallet #3827

0oM4R · 2025-01-20T16:42:38Z

Description

Refactor login and connect wallet

Changes

Profile manager:
- move the logic of connect and login to separate components and use them in Dtab
- remove all the conditional elements that rely on active tab
Env and config.js: use WalletKey from env to make sure that is always consistent on all places
gather all the postLogin needed logic into a util function to be reusable
create components for the moved logic form profile manager
email will be disabled untill the user entered a valid mnemonic to avoid overwriting the entered
enable reload mnemonic validation only if there is an issue with validating a mnemonic:
this means if the entered mnemonic is valid but we couldn't load the grid except TwinNotExistError something like connection error, then we enable the reload

Related Issues

Rewrite profile manager dialog #3805

Tested Scenarios

in incognato mode tabs works fine
create account works fine
activate account with sr25519 works fine
activate accout with ed25519 will show an error
auto login on refresh
email loading and storing works fine
tabs switching is functional

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

Preliminary Checks
- Does it completely address the issue linked?
- What about edge cases?
- Does it meet the specified acceptance criteria?
- Are there any unintended side effects?
- Does the PR adhere to the team's coding conventions, style guides, and best practices?
- Does it integrate well with existing features?
- Does it impact the overall performance of the application?
- Are there any bottlenecks or slowdowns?
- Has it been optimized for efficiency?
- Has it been adequately tested with unit, integration, and end-to-end tests?
- Are there any known defects or issues?
- Is the code well-documented?
- Are changes to documentation reflected in the code?

UI Checks:

UI Checks
- If a UI design is provided/ does it follow it?
- Does every button work?
- Is the data displayed logical? Is it what you expected?
- Does every validation work?
- Does this interface feel intuitive?
- What about slow network? Offline?
- What if the gridproxy/graphql/chain is failing?
- What would a first time user have a hard time navigating here?

Code Quality Checks:

Code Quality Checks
- Code formatted/linted? Are there unused imports? .. etc
- Is there redundant/repeated code?
- Are there conditionals that are always true or always false?
- Can we write this more concisely?
- Can we reuse this code? If yes, where?
- Will the changes be easy to maintain and update in the future?
- Can this code become too complex to understand for other devs?
- Can this code cause future integration problems?

Testing Checklist

Does it Meet the specified acceptance criteria.
Test if changes can affect any other functionality.
Tested with unit, integration, and end-to-end tests.
Tested the un-happy path and rollback scenarios.
Documentation updated to meet the latest changes.
Check automated tests working successfully with the changes.
Can be covered by automated tests.

General Checklist

use wallet key from window.env

create the post login logic

- add form to the login, this will handle the stats tabs more effictive, - remove the emits that change the field status not needed

add connect wallet

… before mnemonics to avoid conflicts and losing entred data

- getting a grid checking a twin should be in validate mnemonic, moved and marked as asyncRule - load email only getting email and set it - also the reload validation now only if there is an issue with getting the grid, in validate mnemonic

- passing the mnemonic or hex to profile - disable password on logning - add emit to update loading

add disabled prop

support create and activate account flow

…into development_rewriteProfileManager

- enhance getting credentials logic

- disable auto complete - set the session password in handlePostLogin

packages/playground/src/utils/profile_manager.ts

add suspense to fallback to the skeletonLoader if one of the commponents is still loading

…e style

remove logs and enhance errors pass the email to postlogin method: to not check if the email is stored; as we already have a new one to store

packages/playground/src/utils/profile_manager.ts

ramezsaeed · 2025-01-29T14:51:06Z

I think this needs docs to be promoted first before we merge it.

ramezsaeed · 2025-01-29T14:57:43Z

Test scenarios to Add:

Test the new login/create account with KYC
Test login with Hex (valid & invalid Hex)
Test login with mnemonic 24 words
Test login with invalid mnemonic
Test valid mnemonic and update the email & passwd

0oM4R · 2025-01-30T09:44:05Z

I think this needs docs to be promoted first before we merge it.

there is no changes in the UI or the current flow, we just refactored the current code

amiraabouhadid

i get this massive error when i reload the your farms page or when I even just go to the home page

…into development_rewriteProfileManager

amiraabouhadid · 2025-02-03T08:53:29Z

please disable password autofill for the mnemonic field in register tab

it gets autofilled whenever I autofill the email and the newly generated mnemonics get lost

amiraabouhadid

this validation should not pass

amiraabouhadid

tested:

creating new account, works
importing account, works
logging in, works
clearing local storage and getting only the register tab, works

amiraabouhadid · 2025-02-03T09:11:34Z

not sure if this console err is related

amiraabouhadid · 2025-02-03T09:13:28Z

not sure if it is wise to use suspense as it is still an experimental feature that may not be added to the API

0oM4R · 2025-02-03T10:06:48Z

not sure if it is wise to use suspense as it is still an experimental feature that may not be added to the API

removed on ef37dee will update the pr body

0oM4R · 2025-02-03T10:12:03Z

please disable password autofill for the mnemonic field in register tab it gets autofilled whenever I autofill the email and the newly generated mnemonics get lost

those are saved by you; you can manage them in your browser settings; i think it will never get autofilled if you didn't click on it right?

amiraabouhadid · 2025-02-03T13:10:55Z

please disable password autofill for the mnemonic field in register tab it gets autofilled whenever I autofill the email and the newly generated mnemonics get lost

those are saved by you; you can manage them in your browser settings; i think it will never get autofilled if you didn't click on it right?

They won't be autofilled if I don't select to autofill the email, yes but would nice to disable it for mnemonics as it is not a password

0oM4R added 18 commits January 16, 2025 16:20

Refactor(ProfileManager):

fbd12b5

use wallet key from window.env

WIP: add password field

6668980

Refactor(ProfileManager):

e2427a3

create the post login logic

Refactor(ProfileManager): create login tab

5cc3af9

Refactor(ProfileManager): create login, enahnce pawwsord field

fe7c495

Refactor(ProfileManager):

0959d9d

- add form to the login, this will handle the stats tabs more effictive, - remove the emits that change the field status not needed

Refactor(ProfileManager)/WIP:

0f60d9e

add connect wallet

Refactor(ProfileManager)/WIP: add a flag to prevent user to add email…

e56c4f7

… before mnemonics to avoid conflicts and losing entred data

Refactor(ProfileManager:TermsDialog

fa22b79

Refactor(ProfileManager:LoginTab):

e02a3bf

- passing the mnemonic or hex to profile - disable password on logning - add emit to update loading

Refactor(ProfileManager:WalletPassword):

4e5c6b2

add disabled prop

Refactor(ProfileManager:ConnectWallet)WIP:

fa7a8b8

support create and activate account flow

Merge branch 'development' of github.com:threefoldtech/tfgrid-sdk-ts …

1121e3e

…into development_rewriteProfileManager

Refactor(ProfileManager:Walletlogin):

1a87fe4

- enhance getting credentials logic

Refactor(ProfileManager:Walletlogin):

dfabd7d

- enhance getting credentials logic

Refactor(ProfileManager:ConnectWallet)WIP:

3332700

- disable auto complete - set the session password in handlePostLogin

github-advanced-security bot found potential problems Jan 23, 2025

View reviewed changes

packages/playground/src/utils/profile_manager.ts Fixed Show fixed Hide fixed

0oM4R added 9 commits January 23, 2025 19:50

Refactor(ProfileManager): apply the new components and cleanup the code

36d2815

Feature(ProfileManager): add skeleton loader

f68826e

Feature(ProfileManager):

2acadf2

add suspense to fallback to the skeletonLoader if one of the commponents is still loading

Chore(ProfileManager:connectWallet): add ids to elements

5211651

Chore(ProfileManager:skeletonLoader): add ids to elements, and enhanc…

b3c9975

…e style

FIX(ProfileManager): remove session storage

fc93a45

FIX(ProfileManager): remove session storage

91b9e14

chore(ProfileManager):

bb5f2eb

remove logs and enhance errors pass the email to postlogin method: to not check if the email is stored; as we already have a new one to store

FIX(ProfileManager): restore session storage

ce9eb7e

github-advanced-security bot found potential problems Jan 29, 2025

View reviewed changes

packages/playground/src/utils/profile_manager.ts Dismissed Show dismissed Hide dismissed

Chore(ProfileManager): fix activate flow and add clear error function

d809598

Chore(ProfileManager): rename files and fix imports

47262c9

0oM4R changed the title ~~Development rewrite profile manager~~ Refactor Connect wallet Jan 29, 2025

Chore(ProfileManager): remove extra lines of enable validation reload

5723b8c

0oM4R marked this pull request as ready for review January 29, 2025 13:18

0oM4R requested review from AhmedHanafy725, zaelgohary, maayarosama, MohamedElmdary, Mahmoud-Emad, amiraabouhadid, AlaaElattar and samaradel as code owners January 29, 2025 13:18

ramezsaeed mentioned this pull request Jan 29, 2025

QA progress threefoldtech/home#1575

Open

amiraabouhadid reviewed Feb 2, 2025

View reviewed changes

0oM4R added 2 commits February 2, 2025 11:26

Merge branch 'development' of github.com:threefoldtech/tfgrid-sdk-ts …

ba96570

…into development_rewriteProfileManager

FIX(ProfileManager): remove suspense to fix recursive calls error

ef37dee

0oM4R requested a review from amiraabouhadid February 2, 2025 10:04

amiraabouhadid requested changes Feb 3, 2025

View reviewed changes

amiraabouhadid reviewed Feb 3, 2025

View reviewed changes

0oM4R marked this pull request as draft February 3, 2025 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Connect wallet #3827

Refactor Connect wallet #3827

0oM4R commented Jan 20, 2025 •

edited

Loading

ramezsaeed commented Jan 29, 2025

ramezsaeed commented Jan 29, 2025

0oM4R commented Jan 30, 2025

amiraabouhadid left a comment •

edited

Loading

amiraabouhadid commented Feb 3, 2025 •

edited

Loading

amiraabouhadid left a comment •

edited

Loading

amiraabouhadid left a comment •

edited

Loading

amiraabouhadid commented Feb 3, 2025

amiraabouhadid commented Feb 3, 2025

0oM4R commented Feb 3, 2025

0oM4R commented Feb 3, 2025

amiraabouhadid commented Feb 3, 2025

Refactor Connect wallet #3827

Are you sure you want to change the base?

Refactor Connect wallet #3827

Conversation

0oM4R commented Jan 20, 2025 • edited Loading

Description

Changes

Related Issues

Tested Scenarios

Documentation PR

To consider

Preliminary Checks:

UI Checks:

Code Quality Checks:

Testing Checklist

General Checklist

ramezsaeed commented Jan 29, 2025

ramezsaeed commented Jan 29, 2025

0oM4R commented Jan 30, 2025

amiraabouhadid left a comment • edited Loading

Choose a reason for hiding this comment

amiraabouhadid commented Feb 3, 2025 • edited Loading

amiraabouhadid left a comment • edited Loading

Choose a reason for hiding this comment

amiraabouhadid left a comment • edited Loading

Choose a reason for hiding this comment

amiraabouhadid commented Feb 3, 2025

amiraabouhadid commented Feb 3, 2025

0oM4R commented Feb 3, 2025

0oM4R commented Feb 3, 2025

amiraabouhadid commented Feb 3, 2025

0oM4R commented Jan 20, 2025 •

edited

Loading

amiraabouhadid left a comment •

edited

Loading

amiraabouhadid commented Feb 3, 2025 •

edited

Loading

amiraabouhadid left a comment •

edited

Loading

amiraabouhadid left a comment •

edited

Loading