Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve :default swagger #47

Merged
merged 21 commits into from
Jul 12, 2024
Merged

Improve :default swagger #47

merged 21 commits into from
Jul 12, 2024

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Jul 8, 2024

https://github.com/advthreat/iroh/issues/8946

Always populate :default so it can be used for :example swagger. Since :default is a declared defrecord field, we need to treat nil as absent. This only seems to affect AnythingType which cannot default to nil.

@frenchy64 frenchy64 changed the title add :example swagger Improve :default swagger Jul 8, 2024
@frenchy64 frenchy64 marked this pull request as ready for review July 9, 2024 00:01
@frenchy64 frenchy64 self-assigned this Jul 9, 2024
Copy link

@yogsototh yogsototh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That's great

src/flanders/example.cljc Outdated Show resolved Hide resolved
src/flanders/example.cljc Outdated Show resolved Hide resolved
@frenchy64 frenchy64 merged commit 2c25c9a into master Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants