remove OpenMP and unlocked stdio? #93
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fun fact, older versions of OpenMP didn't allow unsigned loop indexes, and using them caused UB. |
|
a bug related to OpenMP was fixed recently. i'm honestly not very stoked about the fact that the order in which the files are written relies on omp scheduling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stuff existed from the very beginning of thtk, but I wonder if there's actually any point in it. I made these two commits in order to be able to do comparisons. I don't wanna do it right now though, so I'll let this code sit here in case anyone else wants to benchmark.
I'm fine with keeping unlocked stdio if it has any gains, because the stuff is obviously correct. I'm not so sure with OpenMP, at it causes #52, and that's enough of a reason to get rid of it IMO.