Prerequisites: Raise if Node version unsupported #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #1201 It's not enough to ensure Node is installed. We also need to ensure the consumer has the supported minimum version installed. Otherwise, subsequent generators will raise errors like so: ``` error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.12.0". Got "18.0.0" error Found incompatible module. ``` We select `v20.0.0` as our minimum supported version because it is slated for Active LTS, but is not bleeding edge at [this time][] We also raise when calling the template to avoid unnecessarily generating a new Rails application. [this time]: https://nodejs.org/en/about/previous-releases
The template won't have access to Suspenders, since it's called in isolation.
stevepolitodesign
force-pushed
the
suspenders-3-0-0-node-lts
branch
from
1919849
to
804c465
Compare
Comment on lines
+1
to
+11
| def node_version | ||
| ENV["NODE_VERSION"] || `node --version`[/\d+\.\d+\.\d+/] | ||
| end | ||
|
|
||
| def node_not_installed? | ||
| !node_version.present? | ||
| end | ||
|
|
||
| def node_version_unsupported? | ||
| node_version < "20.0.0" | ||
| end |
There was a problem hiding this comment.
I needed to re-declare these since this template will be treated as a static file when invoked. I can't import Suspenders.
stevepolitodesign
force-pushed
the
suspenders-3-0-0-node-lts
branch
from
804c465
to
ba8e834
Compare
stevepolitodesign
added a commit
that referenced
this pull request
May 8, 2024
After requiring a minimum Node version #1202, we list this, and other system requirements` in an effort to improve the developer experience.
stevepolitodesign
added a commit
that referenced
this pull request
May 8, 2024
After requiring a minimum Node version #1202, we list this, and other system requirements` in an effort to improve the developer experience.
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Follow-up to #1201 It's not enough to ensure Node is installed. We also need to ensure the consumer has the supported minimum version installed. Otherwise, subsequent generators will raise errors like so: ``` error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.12.0". Got "18.0.0" error Found incompatible module. ``` We select `v20.0.0` as our minimum supported version because it is slated for Active LTS, but is not bleeding edge at [this time][] We also raise when calling the template to avoid unnecessarily generating a new Rails application. [this time]: https://nodejs.org/en/about/previous-releases
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
After requiring a minimum Node version #1202, we list this, and other system requirements` in an effort to improve the developer experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1201
It's not enough to ensure Node is installed. We also need to ensure the consumer has the supported minimum version installed. Otherwise, subsequent generators will raise errors like so:
We select
v20.0.0as our minimum supported version because it is slated for Active LTS, but is not bleeding edge at this timeWe also raise when calling the template to avoid unnecessarily generating a new Rails application.