Convert jmesPath object_alias to objectAlias
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module expects jmesPath object` definitions with `object_alias` and `path` keys. To be a valid jmesPath, SecretsManager requires converting `object_alias` to its CamelCase equivalent. Prior to this change no conversion was done which resulted in errors if using `jmesPath`s. To maintain snakecase in the variable definition and keep the documentation accurate, update the module to do the conversion.
clarissalimab
approved these changes
Jan 17, 2024
minaslater
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module expects jmesPath object
definitions withobject_aliasandpathkeys. To be a valid jmesPath, SecretsManager requires convertingobject_alias` to its CamelCase equivalent.Prior to this change no conversion was done which resulted in errors if using
jmesPaths. To maintain snakecase in the variable definition and keep the documentation accurate, update the module to do the conversion.