Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/publihser account cli helpers #667

Merged
merged 21 commits into from
Jan 28, 2025

Conversation

ja573
Copy link
Member

@ja573 ja573 commented Jan 27, 2025

No description provided.

@ja573 ja573 requested a review from rhigman January 27, 2025 15:33
rhigman
rhigman previously approved these changes Jan 28, 2025
Copy link
Member

@rhigman rhigman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great and works well! Only a couple of minor points.

src/bin/thoth.rs Outdated Show resolved Hide resolved
src/bin/commands/account.rs Outdated Show resolved Hide resolved
rhigman
rhigman previously approved these changes Jan 28, 2025
@ja573 ja573 requested a review from rhigman January 28, 2025 13:12
@ja573 ja573 merged commit 9f1c1e2 into develop Jan 28, 2025
13 checks passed
@ja573 ja573 deleted the feature/publihser_account_cli_helpers branch January 28, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants