Feature/324 implement update locations #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen in edit mode (will delete later, as it doesn't work for Add New Location)
Merge from develop
Merge with develop
rhigman
reviewed
Sep 19, 2024
…nt_update_locations' into feature/324_implement_update_locations
rhigman
reviewed
Sep 26, 2024
rhigman
reviewed
Sep 26, 2024
ja573
requested changes
Sep 30, 2024
ja573
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #324
Known bug: When a user views a Canonical Location and exits the modal without making changes by clicking Cancel, X, or outside of the modal, and then opens the modal for another non-Canonical Location, the second Location will sometimes incorrectly display as Canonical: Yes in the modal.
If the user then returns to the Canonical Location without making changes to the second Location, the Canonical Location will sometimes incorrectly display Location Platform: Project MUSE.
In neither case does this affect the underlying values of the fields upon Save; if the user clicks Save when the values are displaying incorrectly, the correct, original values of the fields will be preserved.
This display issue has already been identified in several other parts of the view (see #366).