astroturf: EuiMark
#6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
commented
Aug 1, 2019
| @@ -31,7 +31,7 @@ module.exports = { | |||
| dirname(hostFilePath), | |||
| basename(hostFilePath, extname(hostFilePath)), | |||
| ); | |||
| return `${basepath}_${id}${pluginsOptions.extension}`; | |||
| return `${basepath}${pluginsOptions.extension}`; | |||
There was a problem hiding this comment.
Ignore. Just changing the name of the generated CSS file.
thompsongl
commented
Aug 1, 2019
| @@ -55,7 +55,14 @@ const webpackConfig = { | |||
| test: /\.module\.scss$/, | |||
| loaders: [ | |||
| 'style-loader', | |||
| 'astroturf/css-loader', | |||
| { | |||
There was a problem hiding this comment.
Ignore. Just changing what the generated class names look like.
thompsongl
commented
Aug 1, 2019
| const dark = css` | ||
| @import 'avatar_dark.module'; | ||
| `; | ||
| // const dark = css` |
There was a problem hiding this comment.
Ignore. Removing theming for now.
thompsongl
commented
Aug 1, 2019
| const dark = css` | ||
| @import 'badge_dark.module'; | ||
| `; | ||
| // const dark = css` |
There was a problem hiding this comment.
Ignore. Removing theming for now.
thompsongl
commented
Aug 1, 2019
| @@ -0,0 +1 @@ | |||
| @import 'mark.module'; | |||
There was a problem hiding this comment.
.module just so babel & webpack can distinguish which files to process as modules.
thompsongl
added a commit
that referenced
this pull request
Mar 20, 2020
* added tests for date_modes * added test for EuiCopy * added tests for EuiTreeView * added tests for EuiToggle * test for text-align * added for EuiTab * Update src/components/copy/copy.test.tsx Co-Authored-By: Caroline Horn <[email protected]> * Update src/components/toggle/toggle.test.tsx Co-Authored-By: Caroline Horn <[email protected]> * Update src/components/toggle/toggle.test.tsx Co-Authored-By: Caroline Horn <[email protected]> * Update src/components/toggle/toggle.test.tsx Co-Authored-By: Caroline Horn <[email protected]> * Update src/components/toggle/toggle.test.tsx Co-Authored-By: Caroline Horn <[email protected]> * Update src/components/text/text_align.test.tsx Co-Authored-By: Caroline Horn <[email protected]> * Update src/components/toggle/toggle.test.tsx Co-Authored-By: Caroline Horn <[email protected]> * updated tests * updated toggle to single * changed casting * dateMode tests * dateMode tests (#6) * date_modes test Co-authored-by: Caroline Horn <[email protected]> Co-authored-by: Greg Thompson <[email protected]> Co-authored-by: Greg Thompson <[email protected]>
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS Modules.
cssfromastroturfclassNames in component, referencing them via style object fromcssIgnore all files not related to
EuiMark