Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Run tools" workflow to prevent tools breakage from version bumps #103

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

jingyuanliang
Copy link
Contributor

@jingyuanliang jingyuanliang commented Nov 4, 2023

go-licenses is already practiced by regular builds, but manifest-tool can't build without directories created, and during regular execution they're created when building binaries, while we're skipping it here.

Let's explicitly run go-licenses to get them created here, and this could also provide a clearer signal on go-licenses itself.

The purpose of this is to prevent #102. The failed check execution is due to #102.

go-licenses is already practiced by regular builds, but manifest-tool
can't build without directories created, and during regular execution
they're created when building binaries, while we're skipping it here.

Let's explicitly run go-licenses to get them created here, and this
could also provide a clearer signal on go-licenses itself.
@thockin
Copy link
Owner

thockin commented Nov 4, 2023

I'm not clear how this aims to fix the manifest-tool being broken?

@jingyuanliang
Copy link
Contributor Author

I'm not clear how this aims to fix the manifest-tool being broken?

It's not to fix it right now. It's to prevent it being broken (so the previous dependabot bump would fail checks).

As for fix, I'd recommend reverting that dependabot PR, and wait for a new manifest-tool version with the fix. I feel it's not worth for a revert to be a PR. You can just do it yourself, then this PR can validate the fix.

@thockin
Copy link
Owner

thockin commented Nov 4, 2023

Weirdly:

$ go install github.com/estesp/manifest-tool/v2/cmd/[email protected]

$ go install github.com/estesp/manifest-tool/v2/cmd/manifest-tool
../../../go/pkg/mod/github.com/estesp/manifest-tool/[email protected]/cmd/manifest-tool/main.go:8:2: no required module provides package github.com/docker/docker/cli/config; to add it:
	go get github.com/docker/docker/cli/config

$ grep manifest-tool go.mod 
	github.com/estesp/manifest-tool/v2 v2.0.8

Soit works if I ask for v2.0.8 but not if I don't specify, even though the module uses v2.0.8

@thockin thockin merged commit a1c302b into thockin:master Nov 4, 2023
6 of 8 checks passed
@jingyuanliang
Copy link
Contributor Author

I think I don't have sufficient go knowledge to figure this out without experiments, while I'm currently on my phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants