Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sveltekit netlify adaptor #1065

Merged
merged 5 commits into from
Dec 14, 2022
Merged

fix: Sveltekit netlify adaptor #1065

merged 5 commits into from
Dec 14, 2022

Conversation

markshenouda
Copy link
Member

No description provided.

@markshenouda markshenouda self-assigned this Dec 14, 2022
@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for superb-nasturtium-3dbf18 canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/superb-nasturtium-3dbf18/deploys/639a2a83e3d812000870fb53

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for remarkable-caramel-0ba9f6 canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/remarkable-caramel-0ba9f6/deploys/639a2a83c728960008d644e2

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for jazzy-gecko-7ceb2c canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-gecko-7ceb2c/deploys/639a2a83dc146c00083c3de8

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

❌ Deploy Preview for lively-toffee-ba1c74 failed.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/lively-toffee-ba1c74/deploys/639a2a83c728960008d644e7

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for lucent-kleicha-c0913e canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/lucent-kleicha-c0913e/deploys/639a2a8383cac200099a18e6

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for reliable-hummingbird-e55884 canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/reliable-hummingbird-e55884/deploys/639a2a83c200ee0008d43665

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for elaborate-baklava-440c0a canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/elaborate-baklava-440c0a/deploys/639a2a830e756900096255c1

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for starter-dev-showcases-backend canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev-showcases-backend/deploys/639a2a8378ca6300080c9bc3

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for reliable-scone-7b5c41 canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/reliable-scone-7b5c41/deploys/639a2a83c200ee0008d43660

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for snazzy-cannoli-10a12d canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/snazzy-cannoli-10a12d/deploys/639a2a83e3d812000870fb58

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for starter-dev-backend canceled.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev-backend/deploys/639a2a83082c48000968f412

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

❌ Deploy Preview for qwik-graphql-tailwind failed.

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/qwik-graphql-tailwind/deploys/639a2a83e0dd640008d5536d

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for svelte-kit-scss ready!

Name Link
🔨 Latest commit 937d437
🔍 Latest deploy log https://app.netlify.com/sites/svelte-kit-scss/deploys/639a2a83abbf940009c99f67
😎 Deploy Preview https://deploy-preview-1065--svelte-kit-scss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1065.d1190gmno2hljg.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1065.dbm2zhgk5abrj.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1065.d3sqkonra6x7y9.amplifyapp.com

BigAB
BigAB reviewed Dec 14, 2022
View reviewed changes
svelte-kit-scss/package.json
@@ -41,6 +41,7 @@
"@storybook/svelte": "6.5.14",
"@storybook/testing-library": "0.0.13",
"@sveltejs/adapter-auto": "1.0.0-next.90",
"@sveltejs/adapter-netlify": "^1.0.0-next.74",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we need to add the adapter-netlify ?

https://kit.svelte.dev/docs/adapters

SvelteKit offers a number of officially supported adapters.

You can deploy to the following platforms with the default adapter, adapter-auto:

Cloudflare Pages via adapter-cloudflare
Netlify via adapter-netlify
Vercel via adapter-vercel

Just curious why that didn't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is what on the docs but even with the @sveltejs/adaptor-auto you need to install the @sveltejs/adapter-netlify or you gonna get this error on Netlify
image

BigAB
BigAB approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@BigAB BigAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markshenouda markshenouda merged commit 8d3520b into main Dec 14, 2022
@markshenouda markshenouda deleted the fix-sveltekit-netlify-adaptor branch December 14, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigAB BigAB BigAB approved these changes

Assignees

@markshenouda markshenouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshenouda @BigAB