Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom font #91

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Custom font #91

wants to merge 7 commits into from

Conversation

hidakatsuya
Copy link
Member

@hidakatsuya hidakatsuya commented May 7, 2018

Introduction

It has some different implementations from the official frozen specification thinreports/thinreports#5.

Status

  • Implementation
  • Manual test
  • Some code refactoring
  • Spec

Feature and Specification

See thinreports/thinreports-basic-editor#68

@hidakatsuya hidakatsuya added enhancement New feature or request duplicate This issue or pull request already exists labels May 7, 2018
@hidakatsuya hidakatsuya self-assigned this May 7, 2018
@hidakatsuya hidakatsuya requested a review from maeda-m May 7, 2018 18:55
@timeimp
Copy link

timeimp commented Nov 16, 2018

Hey @hidakatsuya - is there any ETA on this?

I used the fallback fonts to get around Prawn::Encoding::UndefinedConversionError but they failed to activate given the font_family setting on the text boxes inside the tlf file.

To get around it, I had to replace Helvetica with Custom-fallback-font0 to allow 'smart quotes' and other UTF-8 items in generated PDFs (so as to force ttf files).

If there is some other way to get this working, that'd be great.

@hidakatsuya hidakatsuya removed enhancement New feature or request duplicate This issue or pull request already exists labels Jun 20, 2020
@hidakatsuya
Copy link
Member Author

@timeimp
Sorry for the delay in getting back to you. Also, thank you for commenting.

Unfortunately, we have not yet decided on an ETA for this feature, and we need to discuss the specification for it as well.

In addition, the specification is being discussed in thinreports/thinreports#5 (in japanese).

@timeimp
Copy link

timeimp commented Nov 17, 2020

@hidakatsuya No worries (and thanks for your response!).

If you need any help or movement on the spec front, I'm definitely glad to give input on thinreports/thinreports#5. Will set some time aside over the next month to add my 2c on this.

As I see it, being able to visually see the different fonts on board would be a massive plus for Thinreports.

That said, the spec definitely needs careful consideration with all the ways one might use fonts and the implications for rendering on local systems (yay!).

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants