Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vegaLite not vl for symbol name #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamiepratt
Copy link

I believe that vegaLite is the correct symbol name not vl.

@thheller
Copy link
Owner

Which CLJS library expects this? If you are using this in your own code you should require this directly and now use cljsjs shims.

@jamiepratt
Copy link
Author

Hanami expects it:

jsa-aerial/hanami@881a2e4

It seems like actually there was a change in the vega-lite library at some point from vl to vegaLite.

@thheller
Copy link
Owner

I do not know if there is any other library out there using vl, so the only reasonable thing to do here is to export both.

@jamiepratt
Copy link
Author

I'll file a new pull request, hang on.

@thheller
Copy link
Owner

Note that you can just do this in your own code. Doing this in shadow-cljsjs really isn't required.

@jamiepratt
Copy link
Author

Note that you can just do this in your own code. Doing this in shadow-cljsjs really isn't required.

I made the suggested change to the pull request. This might affect other libraries that will now be expecting the 'vegaLite' symbol to be available from the latest cljsjs library so perhaps it makes sense to make the change in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants