Update A7b1 - Recording pre-solve penalties #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer require penalties from before the solve (such as inspection penalties) to be listed before the time on the scorecard.
CarterKoala
commented
Oct 10, 2023
|
LGTM! |
|
Looks like the final example still needs to be updated. Perhaps:
|
CarterKoala
commented
Oct 11, 2023
Fixing the example
|
Actually I think the final example should be deleted. The reg is only applied if there is a penalty, and the example has no penalty. |
CarterKoala
commented
Oct 13, 2023
Co-authored-by: Carter Kucala <[email protected]>
Rouxles
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer require penalties from before the solve (such as inspection penalties) to be listed before the time on the scorecard.